[Solved] UNICODE_OFF broken

Developer VST 3 SDK
1

I can no longer compile with UNICODE_OFF defined in 3.7.0 in windows

\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(129): error C2664: 'Steinberg::int32 Steinberg::tstrlen(const Steinberg::tchar *)': cannot convert argument 1 from 'const Steinberg::Vst::TChar *' to 'const Steinberg::tchar *'
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(129): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(129): error C2664: 'Steinberg::UString::UString(Steinberg::UString &&)': cannot convert argument 1 from 'Steinberg::Vst::TChar *' to 'const Steinberg::UString &'
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(129): note: Reason: cannot convert from 'Steinberg::Vst::TChar *' to 'const Steinberg::UString'
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(129): note: No constructor could take the source type, or constructor overload resolution was ambiguous
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(204): error C2664: 'Steinberg::int32 Steinberg::tstrlen(const Steinberg::tchar *)': cannot convert argument 1 from 'const Steinberg::Vst::TChar *' to 'const Steinberg::tchar *'
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(204): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(204): error C2664: 'Steinberg::UString::UString(Steinberg::UString &&)': cannot convert argument 1 from 'Steinberg::Vst::TChar *' to 'const Steinberg::UString &'
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(204): note: Reason: cannot convert from 'Steinberg::Vst::TChar *' to 'const Steinberg::UString'
\vst3_sdk\public.sdk\source\vst\vstparameters.cpp(204): note: No constructor could take the source type, or constructor overload resolution was ambiguous

Unfortunately I need to be able to do this due to non unicode methods in the code base and working with.

Could this be fixed?

2

we will try to fix it…

here as partial fix:

in pluginterfaces/base/fstrdefs.h

#ifndef UNICODE
inline int32 tstrlen (const char16* str) {return _tstrlen (str);}
#endif

3

thanks!